Sine/Cosine FPL Plot & Lorenz Generator & Processor #200
Conversation
Co-authored-by: John Pearson <[email protected]> Co-authored-by: rwschonberg <[email protected]> Co-authored-by: Richard Schonberg <[email protected]>
…rking lorenz_generator/processor that plots the final lorenz_graphic, but need help on removing graphic and replotting updated graphic in updating_graphic.ipynb.
clewis7
left a comment
clewis7
left a comment
There was a problem hiding this comment.
Once you get the sine/cosine example working, I will take another look at the lorenz portion of the demo.
clewis7
left a comment
clewis7
left a comment
There was a problem hiding this comment.
I think one important thing to note is that the goal of updating the demo is to maintain exactly what the previous demo already has in terms of structure and content but simply change the data being generated so that a user can optionally use fastplotlib for visualization if they want to.
There was a problem hiding this comment.
I still had some changes for the sine/cosine example. I will wait to review the lorenz stuff until this is fixed.
Also, when you are making changes if you could resolve my comments or reply to questions I have about what you wrote as you go through them on the PR that is super helpful for me when reviewing.
There was a problem hiding this comment.
@edwin-ma26 It looks like you went through and just resolved the conversations from before without making the changes.
Resolved. You just forgot to push.
clewis7
left a comment
clewis7
left a comment
There was a problem hiding this comment.
I have some more changes, but the sine/cosine example is almost there :D
Only thing of note is that I had some requested changes in the fastplotlib.ipynb from a comment before that maybe you forgot to push.
We also need to talk about the structure of where to store the demos in improv. Best to discuss in-person (perhaps after lab meeting Monday).
|
Also, might be helpful in the |
|
@jmxpearson should be good to go!! Things got messy making sure that everything aligned with dev. Most relevant files to look at are things in the |
|
Thanks. I should be able to take a look early next week. PR says you still have requested changes @clewis7? |
I cleaned up the code, those are old and outdated. |
4 participants
closes #149 and #104
PR to add two demos using
fastplotlibfor visualizationDemo 1:
ipynband alternate sample processor for visualization usingfastplotlib(instructions for use found in the README)improv-fpl.mp4
Demo 2:
improv-lorenz.mp4